Loading uikit resources via the Node resolver #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://deploy-preview-1246--patternlab-handlebars-preview.netlify.app/?p=all @sghoweri @JosefBredereck can you review again? The tests succeed and the preview works now. |
JosefBredereck
requested review from
JosefBredereck
and removed request for
sghoweri
Comment on lines
+42
to
+48
| } else { | ||
| // For backwards compatibility, name to package calculation is: | ||
| // 1. name -> name | ||
| // 2. name -> uikit-name | ||
| // 3. name -> @pattern-lab/name | ||
| // 4. name -> @pattern-lab/uikit-name | ||
| for (const packageName of [ |
Comment on lines
+70
to
+74
| } else { | ||
| logger.warning( | ||
| `Please update the configuration of UIKit ${uikitConfig.name} with property 'package: ${uikitConfig.package}' in patternlab-config.json. Lookup by 'name' is deprecated and will be removed in the future.` | ||
| ); | ||
| } // [3] |
There was a problem hiding this comment.
Very good message as info for the user
Comment on lines
+9
to
+11
| const resolveFileInPackage = (packageName, ...pathElements) => { | ||
| return require.resolve(path.join(packageName, ...pathElements)); | ||
| }; |
There was a problem hiding this comment.
I checked the spread syntax. It is available since Node V8.x
JosefBredereck
approved these changes
Aug 26, 2020
This was referenced Aug 27, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a retry of #1225 which got reverted because of last-minute issues.
Summary of changes:
require.resolve())