Skip to content

Conversation

JosefBredereck
Copy link
Contributor

@JosefBredereck JosefBredereck commented Aug 29, 2020

Closes #1028
Closes #1176

Summary of changes:

Remove the ability to sort files and folders by the ##- prefix. Since that approach could become unhandy when you want to reorder your patterns.

(Reopening to split changes in code and starter kit file changes)

@JosefBredereck JosefBredereck added breaking ❗ Use this labe if the change will break the current pattern lab behavior WIP 🚶 labels Aug 29, 2020
JosefBredereck added a commit that referenced this pull request Aug 29, 2020
@aleksip
Copy link
Member

aleksip commented Sep 4, 2020

Curious about a few things related to this PR:

  • Does this also add the ability to specify the order in front matter?
  • Will there be a transition period during which both methods are supported, so everything would be ordered based on possible file prefix first, and then based on possible front matter?
  • Is there any estimate for when this will be in a release?

@JosefBredereck
Copy link
Contributor Author

* Does this also add the ability to specify the order in front matter?

yes

* Will there be a transition period during which both methods are supported, so everything would be ordered based on possible file prefix first, and then based on possible front matter?

yes, there will be a transition phase

* Is there any estimate for when this will be in a release?

maybe at the end of september

@aleksip
Copy link
Member

aleksip commented Sep 4, 2020

Awesome, thanks!

@JosefBredereck
Copy link
Contributor Author

See my comments on #1237 for further information on testing.

@JosefBredereck JosefBredereck marked this pull request as ready for review October 24, 2020 12:52
@coveralls
Copy link

coveralls commented Jan 5, 2021

Coverage Status

Coverage decreased (-0.2%) to 76.201% when pulling a75f06e on deprecate-ordering-by-file-prefix into 030a992 on dev.

@JosefBredereck JosefBredereck removed the request for review from sghoweri January 6, 2021 08:05
@JosefBredereck JosefBredereck merged commit d79c29c into dev Jan 6, 2021
JosefBredereck added a commit that referenced this pull request Jan 7, 2021
* Rename files to match #1252 & #1237
* #1253: update dev editions
* #1253 Update doc locations
* #1253 cleanup merge bugs
* #1253 Fix view all pages are not sorted correctly
@JosefBredereck JosefBredereck deleted the deprecate-ordering-by-file-prefix branch January 12, 2021 08:56
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
)

* Remove pattern ordering by file prefix ##-
* pattern-lab#1252: Remove unused code
* pattern-lab#1252 Update pattern doc locations
* pattern-lab#1252 add possibility to disable deprecation warning
* pattern-lab#1252 Fix dev engine twig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking ❗ Use this labe if the change will break the current pattern lab behavior released 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate Pattern Type, Subtype, and Pattern Order using ##-Syntax Remove Pattern Type, Subtype, and Pattern Order mechanic using ##- in the filename

3 participants