refactor(accessibility): optimizations #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same link related to WCAG 1.1.1: Non-text content The text alternative for an image within a link should not repeat the link text or adjacent link text
mfranzke
changed the title
related to 2.4.9 Link Purpose (Link Only)
related to 1.3.1 Info and Relationships and 1.3.2 Meaningful Sequence
multiple elements with "main" role do not have unique labels related to 1.3.1 Info and Relationships, 2.4.1 Bypass Blocks, 3.2.3 Consistent Navigation, 4.1.1 Parsing and 4.1.2 Name, Role, Value
…hem easily Inline frames must have a unique, non-empty 'title' attribute related to 4.1.2 Name, Role, Value
related to WCAG 1.4.3 Contrast (Minimum)
that incorrectly closed <a> tag lead to an additional, empty hyperling - we'd like to prevent this especially for a11y reasons related WCAG 2.4.4 Link Purpose (in Context)
images would either need some alternative textual description, an empty alt-attribute, or be hidden from the accessibility tree related to WCAG 1.1.1 Non-text Content
JosefBredereck
approved these changes
Jun 9, 2021
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* refactor(a11y): link text is repeated in an image 'alt' value within the same link related to WCAG 1.1.1: Non-text content The text alternative for an image within a link should not repeat the link text or adjacent link text * refactor(a11y): prevent ambiguous link names related to 2.4.9 Link Purpose (Link Only) * fix(a11y): heading levels should only increase by one related to 1.3.1 Info and Relationships and 1.3.2 Meaningful Sequence * fix(a11y): removed duplicated <main> tag multiple elements with "main" role do not have unique labels related to 1.3.1 Info and Relationships, 2.4.1 Bypass Blocks, 3.2.3 Consistent Navigation, 4.1.1 Parsing and 4.1.2 Name, Role, Value * refactor(a11y): added necessary title to the iframes to distinguish them easily Inline frames must have a unique, non-empty 'title' attribute related to 4.1.2 Name, Role, Value * fix(a11): ensure a text/background contrast of at least 4.5 : 1 related to WCAG 1.4.3 Contrast (Minimum) * fix(a11y): removed "additional" hyperlink that incorrectly closed <a> tag lead to an additional, empty hyperling - we'd like to prevent this especially for a11y reasons related WCAG 2.4.4 Link Purpose (in Context) * refactor(a11y): hide additive icons images would either need some alternative textual description, an empty alt-attribute, or be hidden from the accessibility tree related to WCAG 1.1.1 Non-text Content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes: