refactor(cli): correct the line endings before publishing #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if this doesn't work, we could try it on postinstall
JosefBredereck
approved these changes
Dec 30, 2021
|
@JosefBredereck I've just resolved the merge conflicts. |
JosefBredereck
approved these changes
Jan 1, 2022
|
PR was released with v5.16.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will most likely solve #967
Summary of changes:
Correcting the line endings before publishing, to prevent errors like the following when using pattern lab cli with yarn:
This is mainly inspired by the comment of @theLine, who suggests to use
dos2unix-cliand we'll try to do this before publishing.If this doesn't work, we could still try to do this with a
"postinstall"script.