Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed polyfill out of codebase #1398

Conversation

mfranzke
Copy link
Contributor

@mfranzke mfranzke commented Dec 25, 2021

Summary of changes:

Removing a remaining polyfill out of the code, as its already included with another polyfill (element-closest).

@mfranzke mfranzke requested a review from sghoweri as a code owner December 25, 2021 20:50
@mfranzke mfranzke marked this pull request as draft December 25, 2021 20:50
as there weren't any relevant changes out of this pull requests code changes
@mfranzke mfranzke marked this pull request as ready for review December 27, 2021 11:44
@mfranzke mfranzke changed the title refactor: integrated polyfill as a dependency refactor: removed polyfill out of codebase Dec 29, 2021
@JosefBredereck JosefBredereck merged commit 712c40e into pattern-lab:dev Dec 30, 2021
@mfranzke mfranzke deleted the refactor/integrated-polyfill-as-a-dependency branch December 31, 2021 05:48
@JosefBredereck
Copy link
Contributor

PR was released with v5.16.0

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
* refactor: integrated polyfill as a dependency

* refactor: .matches polyfill is even already included in .closest polyfill

* refactor: reverted yarn.lock

as there weren't any relevant changes out of this pull requests code changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants