Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated dependency commander #1400

Merged

Conversation

mfranzke
Copy link
Contributor

@mfranzke mfranzke commented Dec 29, 2021

Summary of changes:

We're updating the dependency commander with this pull request. It was mainly about adapting the new example regarding "global" options, as the other aspects shown below weren't affecting us.

Changes to the package

List of all breaking changes according to the commanderpackage changelog:

9.0.0

Changed
Removed

8.0.0

Changed
Removed
  • Breaking: TypeScript declaration for default export of global Command object (#1520)
    • (still available as named program export)

7.0.0

Migration Tips

Changed
  • Breaking: options are stored safely by default, not as properties on the command (#1409)
    • this especially affects accessing options on program, use program.opts()
    • revert behaviour with .storeOptionsAsProperties()
  • Breaking: action handlers are passed options and command separately (#1409)
  • Breaking: errors now displayed using process.stderr.write() instead of console.error()
Deleted
  • Breaking: .passCommandToAction() (#1409)
    • no longer needed as action handler is passed options and command
  • Breaking: "extra arguments" parameter to action handler (#1409)
    • if being used to detect excess arguments, there is now an error available by setting .allowExcessArguments(false)

@mfranzke mfranzke added the dependencies Pull requests that update a dependency file label Dec 29, 2021
@mfranzke mfranzke changed the title refactor: updated dependency commander refactor: updated dependency commander Dec 30, 2021
@mfranzke mfranzke changed the title refactor: updated dependency commander refactor: updated dependency commander Dec 30, 2021
@mfranzke mfranzke self-assigned this Jan 4, 2023
@mfranzke mfranzke marked this pull request as ready for review January 4, 2023 12:32
@JosefBredereck JosefBredereck merged commit 2ea43a9 into pattern-lab:dev Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants