-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: updated dependency commander #1400
Merged
JosefBredereck
merged 20 commits into
pattern-lab:dev
from
mfranzke:refactor/updated-dependency-commander
Jan 7, 2023
Merged
refactor: updated dependency commander #1400
JosefBredereck
merged 20 commits into
pattern-lab:dev
from
mfranzke:refactor/updated-dependency-commander
Jan 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfranzke
changed the title
refactor: updated dependency commander
refactor: updated dependency Dec 30, 2021
commander
mfranzke
changed the title
refactor: updated dependency
refactor: updated dependency commander
Dec 30, 2021
commander
…endency-commander
…endency-commander
JosefBredereck
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
We're updating the dependency
commander
with this pull request. It was mainly about adapting the new example regarding "global" options, as the other aspects shown below weren't affecting us.Changes to the package
List of all breaking changes according to the
commander
package changelog:9.0.0
Changed
Removed
require.main.filename
when script not known from arguments passed to.parse()
(can supply details using.name()
, and.executableDir()
orexecutableFile
) (Rework default program name, and searching for subcommands tj/commander.js#1571)8.0.0
Changed
Help
method.visibleArguments()
returns array ofArgument
(fix(starterkit-twig-demo): pages not rendering pattern-specific data … #1490)CommanderError
codecommander.invalidOptionArgument
renamedcommander.invalidArgument
([Engine Twig PHP] - pattern rendering broken in ^6.0.0 #1508).addTextHelp()
callback no longer allows result ofundefined
, now juststring
(#1516)Removed
Command
object (#1520)program
export)7.0.0
Migration Tips
Changed
program.opts()
.storeOptionsAsProperties()
process.stderr.write()
instead ofconsole.error()
Deleted
.passCommandToAction()
(#1409).allowExcessArguments(false)