Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine-twig-php): twig include function syntax not matched by fin… #1472

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix(engine-twig-php): twig include function syntax not matched by fin… #1472

merged 1 commit into from
Jan 17, 2023
+2 −5

Conversation

hadl
Copy link
Contributor

@hadl hadl commented Jan 15, 2023

Closes: #1471

Summary of changes:
Updated findPartials regex to match twig include function syntax.

https://regexr.com/769fq

@JosefBredereck JosefBredereck merged commit 3677539 into pattern-lab:dev Jan 17, 2023
@hadl hadl deleted the feature/1471-twig-include-function-regex branch February 26, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosefBredereck JosefBredereck JosefBredereck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

engine-twig-php: include-function syntax not matched by findPartials
2 participants
@hadl @JosefBredereck