better regex for replacing single quotes #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this gets merged I'd really like to see parameter_hunter unit tests written to cover the new supported syntaxes, if any. |
|
@bmuenzenmeyer To accommodate the fact the you'd have to run through a matrix of parameter options, I refactored parameter_hunter_test.js to use less repetition of the currentPattern and patternlab objects. Now, the differences between tests are more obvious, and the file overall, is more readable. Unit tests are all passing. Please review. |
|
thanks for the cleanup and the addition tests @e2tha-e |
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Feb 25, 2016
better regex for replacing single quotes
|
@bmuenzenmeyer On my commute to work, I realized I needed to account for more cases, so I'll be revisiting this shortly. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #250 (preliminary work)
Summary of changes:
@bmuenzenmeyer Tightening up the regex for JSON parsing parameter submission. Needed better regex for single-quote wrapped keys. Also, don't need the m flag.