-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hidden pattern references #509
Conversation
…s; unit test to confirm bug in hbs engine; factor out fakePatternLab() into a new module, test_utils.js
…den-pattern-references
# Conflicts: # test/pattern_assembler_tests.js
fixed a merge conflict - going to test this manually too next free time i get - kids up now - dad time |
Groovy. Do that dad time! |
And, thanks for doing the merge. I picked exactly the wrong time to do stuff to unit tests. |
@geoffp does using lineage to go to the hidden pattern work for you? It does not for me using this quick test above |
I'm okay making this a separate issue too if need be. Just curious what is happening on your end. |
@bmuenzenmeyer Just tested -- no, it's not working for me. Separate ticket? |
Addresses #469
Summary of changes:
This is frustratingly simple for how much time it took. Two main changes to the non-test code:
And lots of unit tests to prove it. I created a place for shared code in the tests.