Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert engine_handlebars_tests.js to use tape #526

Merged
merged 2 commits into from
Oct 10, 2016
Merged

Convert engine_handlebars_tests.js to use tape #526

merged 2 commits into from
Oct 10, 2016

Conversation

alexbenic
Copy link
Contributor

Addresses #517

Copy link
Member

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick glance, not sure what is wrong on travis with these four PR that you submitted. will pull down and try at some point if you dont get to it

@alexbenic
Copy link
Contributor Author

It seems to fail against node v4.6. Not sure why, will take a look today.

@alexbenic
Copy link
Contributor Author

I can't reproduce the error using:

  • node -v : v4.6.0
  • npm --version : 2.15.9
  • nvm --version : 0.32.0

I have tested both with and without engines installed. It works as intended.

I could refactor it to use tap, but conditional testing will be less... elegant, since I haven't been able to find test.only equivalent in tap.

@bmuenzenmeyer
Copy link
Member

trying to manually restart that job on travis as a first step

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Oct 10, 2016

pulled this down local - also getting an error the first time I ran, but now no longer....

@alexbenic
Copy link
Contributor Author

I will refactor one test to use tap and see how it goes.

@bmuenzenmeyer
Copy link
Member

@alexbenic glad to see this working - one of my todos will be to convert them all to tap so as to further remove grunt from the equation. thanks for checking this out and getting it working

@bmuenzenmeyer bmuenzenmeyer merged commit ff08f25 into pattern-lab:dev Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants