Added patternlab-pattern-before-data-merge event to enable manipulati… #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of pattern data before it's merged with global
|
A welcome addition - thanks for your interest in Pattern Lab plugins! Keep me posted on your plugin journey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Added an additional event to patternlab.js to after pattern lineages have been set, and before global data has been merged with pattern data. The event is needed to be able to traverse/modify pattern data before the merge occurs.
We were trying to create a plugin similar to the data-inheritance plugin for php when we found there was no suitable event to hook onto. If the naming is incorrect according to any standard defined, I'll happily change it.