Features/376 patternorder #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unit tests to coverage scenario support is only for patterns at this time, not type / subtype documentation / directories part of #376
|
Nice!! I love this. This will move us closer to fully operationalized patterns, since I'm sure nobody wants to call their final components 00-button.whatever. |
|
The rest of this epic will help drive it home too!
…On Fri, Nov 25, 2016, 2:07 PM Geoff Pursell ***@***.***> wrote:
Nice!! I love this. This will move us closer to fully operationalized
patterns, since I'm sure nobody wants to call their final components
00-button.whatever.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#567 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASNw6sDKW2R2YtZ2lI9J4JP9kIQBX6gks5rB0AQgaJpZM4K8sDf>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #376
Summary of changes:
orderproperty within a pattern's optional markdown file, which, if present, will trump the filename.00-filename.mustachehack we have had since day 1 of Pattern Lab.orderproperty within subtype markdown. (this is a good next step, ain't it?)