Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/replace common utils #659

Merged
merged 3 commits into from
May 7, 2017
Merged

Feature/replace common utils #659

merged 3 commits into from
May 7, 2017

Conversation

bmuenzenmeyer
Copy link
Member

Testing a merge against the CI

Summary of changes:

  • Changes plutils.emptyDirectory → fs.emptyDirSync
  • Changes plutils.mergeData → _.merge
  • Changes plutils.shuffle → _.shuffle
  • Changes plutils.isEmptyObject → _.empty

@raphaelokon
Replace common util functions in core
7390846 
Replace plutils.mergeData with _.merge in core/lib/pseudopattern_hunter.js

Replace plutils.mergeData with _.merge in core/lib/list_item_hunter.js

Replace plutils.mergeData with _.merge in core/lib/patternlab.js

Replace plutils.isObjectEmpty with _.empty in core/lib/pattern_assembler.js

Replace plutils.shuffle with _.shuffle in core/lib/pattern_assembler.js

Replace util.emptyDirectory with fs.emptyDirSync in core/lib/starterkit_manager.js
@raphaelokon
Remove unused functions from core/lib/utilities.js
ecb0291
@raphaelokon
Fixing _.emtpy -> _.isEmpty
6a9674b
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 64.142% when pulling 6a9674b on feature/replace-common-utils into 4eff3f2 on dev-3.0.

1 similar comment
@coveralls
Copy link

coveralls commented May 5, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 64.142% when pulling 6a9674b on feature/replace-common-utils into 4eff3f2 on dev-3.0.

@raphaelokon
Copy link
Contributor

Cheers for the test. I fixed a minor error … passing now.

@bmuenzenmeyer bmuenzenmeyer self-assigned this May 6, 2017
@bmuenzenmeyer bmuenzenmeyer merged commit 7971a2e into dev-3.0 May 7, 2017
@bmuenzenmeyer bmuenzenmeyer deleted the feature/replace-common-utils branch October 6, 2017 15:22
@snyk-bot snyk-bot mentioned this pull request Jan 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmuenzenmeyer bmuenzenmeyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmuenzenmeyer @coveralls @raphaelokon