Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Config Option for Pattern State Lineage Ripple Effect #36

Open
bradfrost opened this issue Oct 19, 2017 · 1 comment
Open

Config Option for Pattern State Lineage Ripple Effect #36

bradfrost opened this issue Oct 19, 2017 · 1 comment

Comments

@bradfrost
Copy link
Member

Per discussion over here: pattern-lab/patternlab-php-core#139 (comment)

Having pattern states affect larger components is typically a good idea. If the primary nav isn't done, the header isn't done, which means the homepage isn't done. It's good to visually see that.

But I can also see how people might only want to see a visual for patterns they've explicitly set statuses for, and not have the ripple effect happen. Perhaps there could be a config option that gives people the choice?

@EvanLovely mentioned a boolean flag like stateSetByLineage could be helpful for teams to control whether the ripple effect (current behavior) happens or not.

My gut tells me this is low priority, but it's worth flagging it here.

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Oct 19, 2017

Having pattern states affect larger components is typically a good idea. If the primary nav isn't done, the header isn't done, which means the homepage isn't done. It's good to visually see that.

It's not just visually important, it's vitally important if users rely on state to determine readiness for production. "Done" can mean that it passes rigorous QA, a11y, documentation, and dev standards.

I strongly believe making this a configurable option dilutes the pattern state and pattern lineage feature. If a user wants to designate a pattern with an arbitrary label that does not affect patterns that may consume it, use a tag.

My vote: 👎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants