Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing state from being added to Patterns in lineage. #139

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

EvanLovely
Copy link
Member

Old behavior: if A.twig has a state set and is included in B.twig, then B.twig gets same state.
New behavior: B.twig does not get state from A.twig

@EvanLovely EvanLovely self-assigned this Oct 12, 2017
@EvanLovely
Copy link
Member Author

@EvanLovely EvanLovely merged commit 14cb25f into master Oct 12, 2017
@EvanLovely EvanLovely deleted the feature/state-lineage-fix branch October 12, 2017 23:07
@EvanLovely
Copy link
Member Author

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Oct 13, 2017

I need to double check but i think this is off-spec.

Edit: trying to find clatifying text from Dave. I know we discussed it and then I implemented https://github.com/pattern-lab/patternlab-node/blob/master/core/lib/lineage_hunter.js#L88 with tests.

@bmuenzenmeyer
Copy link
Member

@bmuenzenmeyer
Copy link
Member

Somehow found it screenshot_20171013-002146

@EvanLovely
Copy link
Member Author

@bmuenzenmeyer ok, I've got it back in! See comments over in #142

@bradfrost
Copy link
Member

@EvanLovely @bmuenzenmeyer I really like the ripple effect of state. If the primary nav isn't done, the header isn't done, which means the homepage isn't done. But I can also see how people might only want to flag the patterns themselves and not have the ripple effect happen. Perhaps there could be a config option that gives people the choice? I'd say this is pretty low on the totem pole, but just bringing it up.

@EvanLovely
Copy link
Member Author

@bradfrost Wanna bring it up in The Spec? I like the idea of a stateSetByLineage config option with the default being true to preserve current behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants