-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preventing state from being added to Patterns in lineage. #139
Conversation
I need to double check but i think this is off-spec. Edit: trying to find clatifying text from Dave. I know we discussed it and then I implemented https://github.com/pattern-lab/patternlab-node/blob/master/core/lib/lineage_hunter.js#L88 with tests. |
@bmuenzenmeyer ok, I've got it back in! See comments over in #142 |
@EvanLovely @bmuenzenmeyer I really like the ripple effect of state. If the primary nav isn't done, the header isn't done, which means the homepage isn't done. But I can also see how people might only want to flag the patterns themselves and not have the ripple effect happen. Perhaps there could be a config option that gives people the choice? I'd say this is pretty low on the totem pole, but just bringing it up. |
@bradfrost Wanna bring it up in The Spec? I like the idea of a |
Old behavior: if A.twig has a state set and is included in B.twig, then B.twig gets same state.
New behavior: B.twig does not get state from A.twig