Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern States Should Always Inherit to Consuming Patterns, Not Just When The Consuming Pattern Has a State #313

Closed
bmuenzenmeyer opened this issue Apr 15, 2016 · 2 comments

Comments

@bmuenzenmeyer
Copy link
Member

I am using Pattern Lab Node v1.2.2.

Expected Behavior

Lower pattern states should inherit upwards to consuming patterns, regardless of the consumer's pattern state.

Actual Behavior

Lower pattern states only inherit upwards to consuming patterns when the consumer has a state applied.

Change

Remove logic that checks for a consumer's pattern state prior to inheritance. Update unit tests.
This should be made on the 1.X path and pulled forward into 2.X

Thanks to Jesse for emailing about this issue!

@bmuenzenmeyer
Copy link
Member Author

bmuenzenmeyer commented Apr 16, 2016

This should be live in dev now. I will create and publish a new version soon-ish.

@bmuenzenmeyer
Copy link
Member Author

bmuenzenmeyer commented Apr 18, 2016

Forward port complete into dev-2.0-core 40a041c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant