feature/unit test #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kHeight" & "getUnspentBoxesByAddress" methods
…tion with Mainnet configuration
…tion with Testnet configuration
…, "storedAssetList", "ready" and "close" methods
… "getConnectedInstances" methods
…umber" and "getAddressUnspentBoxes" methods
… and "loadAssets" methods
…loadPools", "getPoolData" and "storedTokenList" methods
|
Hey, @satiparpar, I am reviewing your code. There are a lot of changes, so it might take a long time. I want to ask you about your code: What functionalities did you target when writing the tests? |
|
hey @ahmadyazdanii ; thanks for you careful review . I see your concern and I would like to tell you that I tried my best to cover all aspects of functions to write unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ahmadyazdanii & @hirotadashi ;
This pull request contains the tests for the "ergo.config", "dex.service". "node.service" and "Ergo" sections. Please review them. If there are any changes needed, kindly let me know.
Thank you!