Skip to content

Add Data List Directive with ngdocs and unit tests #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2015
Merged

Add Data List Directive with ngdocs and unit tests #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ module.exports = function (grunt) {
'lib/patternfly/components/d3/d3.js',
'lib/angular/angular.js',
'lib/angular-animate/angular-animate.js',
'lib/lodash/lodash.min.js',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the addition of lodash here even though I am supportive of using the library within applications. We need to make sure that future commits don't use functions that are in lodash but not in underscore since these need to be interchangeable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

'dist/angular-patternfly.js',
'lib/patternfly/dist/js/patternfly.js'],
html5Mode: false,
Expand Down Expand Up @@ -156,6 +157,11 @@ module.exports = function (grunt) {
cwd: 'src/',
src: ['charts/**/*.html'],
dest: 'templates/charts.js'
},
'patternfly.views': {
cwd: 'src/',
src: ['views/**/*.html'],
dest: 'templates/views.js'
}
},
// ng-annotate tries to make the code safe for minification automatically
Expand Down
1 change: 1 addition & 0 deletions bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
"angular-sanitize": "1.3.*",
"angular-touch": "1.3.*",
"angular-route": "1.3.*",
"lodash": "3.x",
"patternfly": "~2.0.0"
}
}
Loading