Skip to content

Commit

Permalink
fix(jump-links): landmark label
Browse files Browse the repository at this point in the history
Closes #2860
  • Loading branch information
bennypowers committed Oct 27, 2024
1 parent 9637998 commit 017052e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions .changeset/grumpy-lemons-like.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
"@patternfly/elements": patch
---
`<pf-jump-links>`: improve screen reader accessibility by labeling the navigation landmark element
2 changes: 1 addition & 1 deletion elements/pf-jump-links/pf-jump-links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export class PfJumpLinks extends LitElement {

render(): TemplateResult<1> {
return html`
<nav id="container">${this.expandable ? html`
<nav id="container" aria-labelledby="label">${this.expandable ? html`
<details ?open="${this.expanded}" @toggle="${this.#onToggle}">
<summary>
<pf-icon icon="chevron-right"></pf-icon>
Expand Down

0 comments on commit 017052e

Please sign in to comment.