Use shadow dom #1220
Merged
Use shadow dom #1220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redallen
reviewed
Jun 6, 2019
|
|
||
| const packageJson = require('../package.json'); | ||
| // get the specific version of patternfly as used by the react examples | ||
| const pfVersion = packageJson.dependencies['@patternfly/src-patternfly-next'].split('#v')[1]; |
Contributor
There was a problem hiding this comment.
I'm about to break this with submodules. I don't mind fixing it, just tell me what exactly it's doing.
Collaborator
Author
There was a problem hiding this comment.
actually i think i'll take another look at this. basically i need to load one set of patternfly css for the core examples, and one set for the react examples, since they may not be in sync
Contributor
There was a problem hiding this comment.
We fixed this making the version of @patternfly/patternfly in _repos/react-core exactly the version in _repos/core.
redallen
reviewed
Jun 6, 2019
| // patternfly-icons assumes classes are nested under html tag, doesn't work in shadow dom so strip them out | ||
| const strippedHtmlIconsStyles = patternFlyIcons.replace(/html\s/g, ''); | ||
| return ( | ||
| <ShadowDOM> |
Contributor
There was a problem hiding this comment.
Much simpler than I anticipated!
redallen
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use shadow-dom for the examples so they do not accidentally receive css overrides from the website styling