feat(submodules): remove patternfly-react submodule, add react-docs #1734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redallen
changed the title
Collaborator
|
PF3 preview: https://patternfly-org-pr-1734-v3.surge.sh/v3 |
jschuler
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the PRs I'm more proud of. Took some reverse engineering https://github.com/gatsbyjs/gatsby/blob/9d5371adc3e40e9af4dec0e35a3ad18a238fedaf/packages/gatsby/src/utils/webpack-utils.ts#L312 since Gatsby now uses TWO Babel configs (one for node_modules and one for "userspace" code), but I got it!
Also throw in the new upload script so uploads happen in the same build step docs are built.
Closes #1732