Releasenotes toc has gutter 1823 #1824
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated release notes toc template so that it use the new "hasGutter" prop opposed to gutter=" notation
ddonahue007
requested review from
dlabrecq,
evwilkin,
jschuler,
mcoker and
redallen
Collaborator
|
PF3 preview: https://patternfly-org-pr-1824-v3.surge.sh/v3 |
redallen
approved these changes
Apr 29, 2020
Contributor
redallen
left a comment
redallen
left a comment
There was a problem hiding this comment.
I changed the base branch to v4 for you and it looks good :)
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1823
The padding between the release note cards is not correct. The fix is to move to using the new "hasGutter" prop.
How it is now:
How it should be: