Skip to content

Conversation

@srambach
Copy link
Member

Fixes #3184
Adds IsWidthLimited to the description section, but since that adds a pf-c-page__main-body with its own padding, I had to remove the utility class on the page section and instead directly modify the variable to remove top padding on pf-c-page__main-body.

@srambach srambach requested review from evwilkin and mcoker October 17, 2022 15:58
@patternfly-build
Copy link
Collaborator

patternfly-build commented Oct 17, 2022

evwilkin
evwilkin previously approved these changes Oct 17, 2022
Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I reviewed with @mceledonia and @lboehling and agreed the title and description should just use our default content/text styling. Then we can remove the extra section with the inline padding style.

Screen Shot 2022-10-19 at 10 05 38 AM

WDYT about the community page and the footers?

Screen Shot 2022-10-18 at 3 59 05 PM

Screen Shot 2022-10-18 at 3 58 53 PM

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, just one thing it looks like.

export const Footer = () => (
<React.Fragment>
<PageSection key="footer-1" className="ws-org-pfsite-l-footer">
<PageSection isWidthLimited key="footer-1" className="ws-org-pfsite-l-footer">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is creating some padding action for this block since there are custom padding styles defined here

.ws-org-pfsite-l-footer.pf-c-page__main-section {
font-family: "RedHatText";
font-weight: 300;
background-color: #1a1a1a !important;
padding: 48px;
padding-top: 32px;
/* Hide long overflowing tocs */
z-index: 1;
}

Easiest fix if we want to leave it the way it is would probably just be to set the right vars there, since the body element inherits the main-section's padding vars.

So like:

--pf-c-page__main-section--PaddingTop: var(--pf-global--spacer--xl);
--pf-c-page__main-section--PaddingRight: var(--pf-global--spacer--2xl);
--pf-c-page__main-section--PaddingBottom: var(--pf-global--spacer--2xl);
--pf-c-page__main-section--PaddingLeft: var(--pf-global--spacer--2xl);

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just poking around, I think this looks a little odd on the home page since the home page content is centered. Maybe that's OK?

Screen Shot 2022-10-21 at 4 37 51 PM

Here is what it looks like if we use the isCenterAligned prop

Screen Shot 2022-10-21 at 4 38 28 PM

This is what it looks like with that set on component pages - wdyt @mceledonia @lboehling?

Screen Shot 2022-10-21 at 4 37 42 PM

FWIW it's currently centered on component pages, it just grows to fill the viewport width.

Screen Shot 2022-10-21 at 4 42 44 PM

@mceledonia
Copy link

@mcoker @srambach I think the footer is fine stretching to fill width, then we don't need to worry as much about the alignment. Unless there's a better reason for it to be limited, let me know!

Other than that I think these changes to the description section look great.

@srambach srambach force-pushed the 3184-add-is-width-limited branch from 42f2466 to 378e5c3 Compare October 24, 2022 19:28
@srambach srambach requested a review from mcoker October 24, 2022 19:42
@srambach srambach force-pushed the 3184-add-is-width-limited branch from 378e5c3 to 83ea73f Compare October 25, 2022 15:48
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@evwilkin evwilkin merged commit 3080e84 into patternfly:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some page sections should be width limited

5 participants