Skip to content

fix(Tables): temporarily comment out tables so Table can be deprecated #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 1 commit into from
Apr 3, 2023
Merged

fix(Tables): temporarily comment out tables so Table can be deprecated #3468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/documentation-framework/components/cssVariables/cssVariables.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import React from "react";
import { debounce } from "@patternfly/react-core";
import {
Table,
TableHeader,
TableBody,
// Table,
// TableHeader,
// TableBody,
sortable,
SortByDirection,
expandable
Expand Down Expand Up @@ -210,7 +210,7 @@ export class CSSVariables extends React.Component {
return (
<React.Fragment>
<CSSSearch getDebouncedFilteredRows={this.getDebouncedFilteredRows} />
<Table
{/* <Table
variant="compact"
aria-label={`CSS Variables for prefixes ${this.prefix.join(" ")}`}
sortBy={this.state.sortBy}
Expand All @@ -226,7 +226,7 @@ export class CSSVariables extends React.Component {
>
<TableHeader />
<TableBody />
</Table>
</Table>*/}
</React.Fragment>
);
}
Expand Down
18 changes: 9 additions & 9 deletions packages/documentation-framework/components/propsTable/propsTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import React from "react";
import { Badge } from "@patternfly/react-core";
//import { Badge } from "@patternfly/react-core";
import {
Table,
TableHeader,
TableBody,
// Table,
// TableHeader,
// TableBody,
cellWidth,
} from "@patternfly/react-table";
import { AutoLinkHeader } from "../autoLinkHeader/autoLinkHeader";
import { PropTypeWithLinks } from "./propTypeWithLinks";
import { css } from "@patternfly/react-styles";
import accessibleStyles from "@patternfly/react-styles/css/utilities/Accessibility/accessibility";
//import { PropTypeWithLinks } from "./propTypeWithLinks";
//import { css } from "@patternfly/react-styles";
//import accessibleStyles from "@patternfly/react-styles/css/utilities/Accessibility/accessibility";

export const PropsTable = ({ title, description, rows, allPropComponents }) => {
const columns = [
Expand All @@ -22,7 +22,7 @@ export const PropsTable = ({ title, description, rows, allPropComponents }) => {
return (
<React.Fragment>
<AutoLinkHeader size="h3">{title}</AutoLinkHeader>
<Table
{/*<Table
className="pf-u-mt-md pf-u-mb-lg"
variant="compact"
aria-label={title}
Expand Down Expand Up @@ -85,7 +85,7 @@ export const PropsTable = ({ title, description, rows, allPropComponents }) => {
>
<TableHeader />
<TableBody />
</Table>
</Table>*/}
</React.Fragment>
);
};