Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pf 6 alpha banner to home page and version switcher #3896

Merged
merged 2 commits into from
Mar 19, 2024
Merged

feat: add pf 6 alpha banner to home page and version switcher #3896

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d74fa9
feat: add pf 6 alpha banner to home page and version switcher
nicolethoen Feb 21, 2024
ce4e084
update wording
nicolethoen Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,12 +163,26 @@ const HeaderTools = ({
</DropdownList>
</DropdownGroup>
)}
<Divider key="divider" className="ws-switcher-divider"/>
<Divider key="divider1" className="ws-switcher-divider"/>
<DropdownGroup key="Alpha preview version" label="Alpha preview version">
<DropdownList>
<DropdownItem
key="PatternFly 6"
className="ws-patternfly-versions"
isExternalLink
to="https://staging-v6.patternfly.org/"
itemId="patternfly-6"
>
PatternFly 6
</DropdownItem>
</DropdownList>
</DropdownGroup>
<Divider key="divider2" className="ws-switcher-divider"/>
<DropdownGroup key="Previous versions" label="Previous versions">
<DropdownList>
<DropdownItem
key="PatternFly 4"
className="ws-patternfly-3"
className="ws-patternfly-versions"
isExternalLink
to="http://v4-archive.patternfly.org/v4/"
itemId="patternfly-4"
Expand All @@ -177,7 +191,7 @@ const HeaderTools = ({
</DropdownItem>
<DropdownItem
key="PatternFly 3"
className="ws-patternfly-3"
className="ws-patternfly-versions"
isExternalLink
to="https://pf3.patternfly.org/"
itemId="patternfly-3"
Expand Down
2 changes: 1 addition & 1 deletion packages/documentation-framework/templates/mdx.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#ws-page-content-router {
display: flex;
flex-direction: column;
height: 100%;
flex-shrink: 0;
}

.ws-release-notes-toc {
Expand Down
2 changes: 1 addition & 1 deletion packages/documentation-site/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"screenshots": "pf-docs-framework screenshots"
},
"dependencies": {
"@patternfly/documentation-framework": "^5.3.20",
"@patternfly/documentation-framework": "^5.4.2",
"@patternfly/quickstarts": "^5.1.0",
"@patternfly/react-catalog-view-extension": "5.0.0",
"@patternfly/react-console": "5.0.0",
Expand Down
4 changes: 4 additions & 0 deletions packages/documentation-site/patternfly-docs/pages/home.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
FlexItem,
Grid,
PageSection,
PageSectionVariants,
Title,
Text,
TextVariants,
Expand Down Expand Up @@ -157,6 +158,9 @@ const FeaturedBlogCard = ({postData, idx}) => {

const HomePage = () => (
<React.Fragment>
<PageSection variant={PageSectionVariants.light} stickyOnBreakpoint={{ default: 'top' }} className="pf-v5-u-font-size-lg">
PatternFly 6 alphas are available! Visit the PatternFly 6 staging website (still in in process) for new design, code samples, and documentation. <a href="https://staging-v6.patternfly.org/" className="pf-v5-u-font-weight-bold">Go to PatternFly 6 <ArrowRightIcon /></a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PatternFly 6 alphas are available! Visit the PatternFly 6 staging website (still in in process) for new design, code samples, and documentation. <a href="https://staging-v6.patternfly.org/" className="pf-v5-u-font-weight-bold">Go to PatternFly 6 <ArrowRightIcon /></a>
The PatternFly 6 alpha release is available! Our staging website (still under development) has a fresh look, along with new styles, code samples, and documentation. <a href="https://staging-v6.patternfly.org/" className="pf-v5-u-font-weight-bold"> Go to PatternFly 6 <ArrowRightIcon /></a>

some rephrasing ideas ~

it could also make sense to remove "(still under development)" and add a separate banner to the staging site? That way the development status context is visible in the location it applies to

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that - I'll put up a PR shortly with a 'still under development' banner on the alpha docs.

</PageSection>
<PageSection isWidthLimited className="ws-homepage-main-section">
<Flex
direction={{default: "column", lg: "row"}}
Expand Down
Loading