chore(styles): Remove custom styles for the css vars table #4110
Conversation
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
LGTM! Just one thing about the circle potentially disappearing if it's the same color as the background behind the circle. And another comment for later I imagine.
| style={{ backgroundColor: value }} | ||
| /> | ||
| <Icon> | ||
| <CircleIcon color={value}/> |
There was a problem hiding this comment.
Looks like the previous circle had a border and box shadow, which we probably want to retain at least one of those for when the circle's color is the same or really close to the background color.
And this is probably something for later, but we're showing the hex value for the color both as the text in the table (#0066cc) but also as the color of the icon (color="#0066cc"), which isn't accurate in dark theme. Technically this applies to other global vars, too, but mostly colors. For colors, you could just use the component var the table row is referencing for the circle color since component vars are available at the :root document scope.
|
Seeing this, I think it may not be super accessible the way you've removed the hex values. They might need to be there? |
4 participants
Closes #4059