Skip to content

Conversation

@nicolethoen
Copy link
Collaborator

@nicolethoen nicolethoen commented Sep 14, 2024

@patternfly-build
Copy link
Collaborator

patternfly-build commented Sep 14, 2024

@edonehoo
Copy link
Collaborator

It looks like some of the formatting isn't applying, like the backtick code styling (maybe not too big a deal) and markdown tables (matters more)

@nicolethoen
Copy link
Collaborator Author

I'll take another pass through and clean up bcakticks and markdown tables. I"d been trying to remove those 👍🏻

@nicolethoen
Copy link
Collaborator Author

I don't think it's super quick to fix the backticks so they are styled like other markdown pages. I think that could be a follow up if needed.

Copy link
Collaborator

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still see some md table formatting when I view the preview link, but I can also see that you removed it in your pr, so I think it's just the preview showing that. I don't think the backtick/code formatting really matters honestly--especially since it's time consuming to edit--devs will understand it regardless. I can edit in a followup if we do want the visual consistency, though!

@nicolethoen nicolethoen merged commit 099b4a0 into patternfly:main Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document list of breaking changes for penta

3 participants