feat(site): fix build for prerelease, use editorial content #4271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
Author
|
@tlabaj The changes in edit - update with version bump and fix went in another PR and got merged so should be set |
kmcfaul
force-pushed
the
editorial-text
branch
from
a5e0599 to
dc68e9d
Compare
mcoker
reviewed
Sep 27, 2024
packages/documentation-framework/components/sectionGallery/TextSummary.js
Show resolved
Hide resolved
mcoker
reviewed
Sep 27, 2024
packages/documentation-framework/components/sectionGallery/sectionDataListLayout.js
Outdated
Show resolved
Hide resolved
mcoker
reviewed
Sep 27, 2024
Comment on lines
189
to
190
| className="pf-v6-u-font-size-lg" | ||
| isEditorial |
Contributor
There was a problem hiding this comment.
This element has the utility class className="pf-v6-u-font-size-lg", which will override isEditorial - want to try removing the utility class font-size and see if the isEditorial styling gives either the same or an appropriate font-size?
|
clicked aroudn through several pages and from what i can tell this looks good from the design side! |
nicolethoen
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4169.