-
Notifications
You must be signed in to change notification settings - Fork 43
PatternFly.org quick starts content edits #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for quickstarts ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
First round of edits. I could add more specific documentation for the examples if that would be valuable, but I already made a lot of edits and didn't want to get too ahead of myself. |
|
Thank you, @edonehoo ! @jessiehuff , are you the person who can merge this for us? I always tag Margot to merge design guidelines, but since this doc is for extensions, I'm not sure who the right person is 🙂 |
| id: Quick starts | ||
| # Tab | ||
| source: In-App-Documentation | ||
| source: In\-app-documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the \ might be a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually trying to escape the hyphen so that it would show up on the site as "In-app documentation" instead of "In app documentation"! It seemed like hyphens in the code weren't showing on the site, but I also wasn't sure if I understood how the webpage was building correctly. Do you know if that understanding is correct and if there's a way to make hyphens show?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @jessiehuff wanted to loop back around on this question when you have a chance!
|
hi! @evwilkin could you let me know if my latest change uses tabName properly? Also - I know your issue/pr is merged and closed, but is the code change fully live? Meaning: once my edits are good to go can I merge and close this pr? |
|
@edonehoo you'll want to keep the My PR was merged into the |
evwilkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Yeah as I understand it the locked version would make this not work properly locally, but after a quick swing at opening the versioning up to get those recent changes in didn't go well as it caused other dependency issues. |
jessiehuff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We'll create a follow up issue for the build concerns.
|
🎉 This PR is included in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes patternfly/patternfly-org#3234
Reviews and edits content for quick starts and in app documentation.