Remove redundant TypeScript job in CI actions #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a review of this PR to also be a review of #147, which I merged by accident 🤦. I'll address any feedback on both changes here, and I promise not to merge this one early 😄
In #147 I added 4 parallel CI jobs for typechecking, linting, running tests and running a build. I opened #148 to see it in action, and realized that any failure of the TypeScript job would also cause both the test and the build jobs to fail. Moreover, the test job shows the full tsc output even though the tsc job doesn't (something about running it via jest?).
At any rate, the standalone typechecking job is unnecessary. This PR removes it and leaves "CI / Lint", "CI / Test" and "CI / Build". I still think it's helpful to have the jobs separated so you can see feedback as soon as possible, easily see which check is failing when viewing the PR, and see all results if multiple things fail (e.g. you have a lint error but you also have an unrelated test failure, and your app still builds).