Skip to content

Commit

Permalink
bug(Select): expose height and max height props for Menu content (#10075
Browse files Browse the repository at this point in the history
)

* bug(Select): expose height and max height props for Menu contnet

* add isScrollable prop

* Update packages/react-core/src/components/Select/Select.tsx

Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>

---------

Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
  • Loading branch information
tlabaj and thatblindgeye authored Feb 28, 2024
1 parent 04f1cf7 commit 47e52de
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion packages/react-core/src/components/Select/Select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,12 @@ export interface SelectProps extends MenuProps, OUIAProps {
role?: string;
/** Additional properties to pass to the popper */
popperProps?: SelectPopperProps;
/** Height of the select menu */
menuHeight?: string;
/** Maximum height of select menu */
maxMenuHeight?: string;
/** Indicates if the select menu should be scrollable */
isScrollable?: boolean;
}

const SelectBase: React.FunctionComponent<SelectProps & OUIAProps> = ({
Expand All @@ -87,6 +93,9 @@ const SelectBase: React.FunctionComponent<SelectProps & OUIAProps> = ({
zIndex = 9999,
role = 'listbox',
popperProps,
menuHeight,
maxMenuHeight,
isScrollable,
...props
}: SelectProps & OUIAProps) => {
const localMenuRef = React.useRef<HTMLDivElement>();
Expand Down Expand Up @@ -151,14 +160,17 @@ const SelectBase: React.FunctionComponent<SelectProps & OUIAProps> = ({
}}
isPlain={isPlain}
selected={selected}
isScrollable={isScrollable}
{...getOUIAProps(
Select.displayName,
props.ouiaId !== undefined ? props.ouiaId : getDefaultOUIAId(Select.displayName),
props.ouiaSafe !== undefined ? props.ouiaSafe : true
)}
{...props}
>
<MenuContent>{children}</MenuContent>
<MenuContent menuHeight={menuHeight} maxMenuHeight={maxMenuHeight}>
{children}
</MenuContent>
</Menu>
);
return (
Expand Down

0 comments on commit 47e52de

Please sign in to comment.