fix: prevent console warning in checkbox & radio (#10048)

patternfly · Jan 29, 2024 · 8709f20 · 8709f20
1 parent f62813f
commit 8709f20
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/react-core/src/components/Checkbox/Checkbox.tsx b/packages/react-core/src/components/Checkbox/Checkbox.tsx
@@ -137,7 +137,7 @@ class Checkbox extends React.Component<CheckboxProps, CheckboxState> {
  const labelRendered = label ? (
  <Label
  className={css(styles.checkLabel, isDisabled && styles.modifiers.disabled)}
- htmlFor={!wrapWithLabel && props.id}
+ htmlFor={!wrapWithLabel ? props.id : undefined}
  >
  {label}
  {isRequired && (
@@ -154,7 +154,7 @@ class Checkbox extends React.Component<CheckboxProps, CheckboxState> {
  return (
  <Component
  className={css(styles.check, !label && styles.modifiers.standalone, className)}
- htmlFor={wrapWithLabel && props.id}
+ htmlFor={wrapWithLabel ? props.id : undefined}
  >
  {isLabelBeforeButton ? (
  <>

diff --git a/packages/react-core/src/components/Radio/Radio.tsx b/packages/react-core/src/components/Radio/Radio.tsx
@@ -119,7 +119,7 @@ class Radio extends React.Component<RadioProps, { ouiaStateId: string }> {
  const labelRendered = label ? (
  <Label
  className={css(styles.radioLabel, isDisabled && styles.modifiers.disabled)}
- htmlFor={!wrapWithLabel && props.id}
+ htmlFor={!wrapWithLabel ? props.id : undefined}
  >
  {label}
  </Label>
@@ -130,7 +130,7 @@ class Radio extends React.Component<RadioProps, { ouiaStateId: string }> {
  return (
  <Component
  className={css(styles.radio, !label && styles.modifiers.standalone, className)}
- htmlFor={wrapWithLabel && props.id}
+ htmlFor={wrapWithLabel ? props.id : undefined}
  >
  {isLabelBeforeButton ? (
  <>