fix(Chip): prevented duplicate ID being applied (#9886)

* fix(Chip): prevented duplicate ID being applied * Updated snapshot * Updated integration test selector
patternfly · Jan 3, 2024 · 91b7d62 · 91b7d62
1 parent 25223e7
commit 91b7d62
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/packages/react-core/src/components/Chip/Chip.tsx b/packages/react-core/src/components/Chip/Chip.tsx
@@ -149,6 +149,8 @@ class Chip extends React.Component<ChipProps, ChipState> {
       isOverflowChip,
       // eslint-disable-next-line @typescript-eslint/no-unused-vars
       tooltipPosition,
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
+      id: idProp,
       component,
       ouiaId,
       textMaxWidth,

diff --git a/packages/react-core/src/components/Chip/__tests__/__snapshots__/Chip.test.tsx.snap b/packages/react-core/src/components/Chip/__tests__/__snapshots__/Chip.test.tsx.snap
@@ -7,7 +7,6 @@ exports[`Matches snapshot 1`] = `
     data-ouia-component-id="snapshot-test"
     data-ouia-component-type="PF5/Chip"
     data-ouia-safe="true"
-    id="snapshot-test"
   >
     <span
       class="pf-v5-c-chip__content"

diff --git a/packages/react-integration/cypress/integration/chip.spec.ts b/packages/react-integration/cypress/integration/chip.spec.ts
@@ -4,7 +4,7 @@ describe('Chip Group Demo Test', () => {
   });
 
   it('Verify tooltipPosition is passed to Tooltip', () => {
-    cy.get('#longName-chip').focus();
+    cy.get('.pf-v5-c-chip').focus();
     cy.get('.pf-v5-c-tooltip').should('have.class', 'pf-m-bottom');
   });
 });