-
Notifications
You must be signed in to change notification settings - Fork 376
Description
In #2360, I noted a couple of additional nice-to-haves:
-
It would be better to expose all formatter/transformer props in
Table.tsxwith our explicitly defined types. Doing so would also require ensuring all formatters and transformers are tested via that interface (as explicit props toTable). feat(react-table): convert react-table to typescript #2360 (comment) -
Ensure that Prettier formatter is applied to React-Table after it is applied in React-Core: Code style/formatting rules for TypeScript are not enforced by TSLint #2362
-
Determine if we'd like to introduce breaking API changes for the
tslintsettings different from React-Core: feat(react-table): convert react-table to typescript #2360 (comment) -
Add Cypress/e2e tests
-
Consider using an interface for static type analysis of aria props/captions/headers. See comment here.
-
Consider rewriting this logic in
collapsible.tsxfor better type analysis: feat(react-table): convert react-table to typescript #2360 (comment) -
Update event types in
selectable.tsx: see comment