-
Notifications
You must be signed in to change notification settings - Fork 377
Closed
Description
In this issue, I will try to capture additional needs for the upcoming Inline Edit feature 😸 . Please feel free to append...
This issue will include the following:
- Provide an implementation of the new Inline Editable table coming to PF Core. Link to PF Core issue.
- Refactor inline editable row and inline editable table to meet latest design spec and Core HTML/CSS (following). This will involve revisiting and refactoring the existing source in
@patternfly/react-inline-edit-extension. Special consideration should be taken to ensure this is now consistent w/ our current React-Table implementation. - Use TypeScript and available React-Table types/interfaces exposed in feat(react-table): convert react-table to typescript #2360 where possible. Link to a relevant comment and another comment.
- Expose the new InlineEditable source from
@patternfly/react-tableinstead of@patternfly/react-inline-edit-extension. We'd like to make this part of the Core distribution of React Table going forward.
This may also include additions to the Toolbar in React-Core for the new design as well as demos integrated w/ the Inline Edit Toolbar options in the Inline Edit examples.