DataToolbarFilter: Maximum update depth exceeded

[dlabrecq]

In Cost Management, we discovered a "Maximum update depth exceeded" issue with the data toolbar.

Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops

This appears to be a problem with how the PatternFly requires a unique DataToolbarFilter component to represent the chip values for each tag below. If there are 100 tags, we end up with 100 DataToolbarFilter components.

[dlabrecq]

A possible workaround is to return null instead of relying on the showToolbarItem prop of DataToolbarFilter. For example:

Ideally, the showToolbarItem prop would not render the DataToolbarFilter Vs only hiding it.

[dlabrecq]

Not the best workaround. We discovered that the "Clear all filters" link will remain after clearing multiple categories.

When we return null, the numberOfFilters state of DataToolbar appears to break, so the clear button is shown incorrectly.

It appears that pf-m-hidden isn't being applied properly. In the snapshot below, pf-c-data-toolbar__group is empty, but pf-c-data-toolbar__item still contains the clear button.

[redallen]

#4056 was reverted, reopening