-
Notifications
You must be signed in to change notification settings - Fork 376
Closed
Labels
Breaking change 💥this change requires a major release and has API changes.this change requires a major release and has API changes.
Milestone
Description
As part of patternfly/patternfly#2816, we dropped the pf-m-no-padding-mobile class and replaced it with the use of pf-m-padding[-on{breakpoint}] and pf-m-no-padding[-on{breakpoint}].
We will need to update page sections to support those classes and their ability to be applied to a single element like pf-m-no-padding, pf-m-padding-on-md, pf-m-no-padding-on-lg, pf-m-padding-on-xl, which would remove default padding, add it back on md viewports, remove it on lg, added it back on xl.
Also the existing noPaddingMobile prop can be updated from using .pf-m-no-padding-mobile (no longer exists) to use .pf-m-no-padding.pf-m-padding-on-md.
- @tlabaj curious what you think of that, creating
noPaddingMobilefrom a combination of classes in core. Does that seem OK, or for something specific like that, would you prefer core manage that combination and continue to offer a class like.pf-m-no-padding-on-mobile?
Metadata
Metadata
Assignees
Labels
Breaking change 💥this change requires a major release and has API changes.this change requires a major release and has API changes.