Skip to content

Chip - remove pf-m-read-only from isReadOnly variant #4071

@mcoker

Description

@mcoker

For reference, the core PR: patternfly/patternfly#2941

The .pf-m-read-only class was only for styling in core, and it's no longer needed as you can simply remove the close button. So we can remove that class from being applied when isReadOnly is true, and just show the close button.

Looks like the isReadOnly && styles.modifiers.readOnly bit in these lines

className={css(styles.chip, isReadOnly && styles.modifiers.readOnly, className)}

className={css(styles.chip, isReadOnly && styles.modifiers.readOnly, className)}

Metadata

Metadata

Assignees

Labels

Breaking change 💥this change requires a major release and has API changes.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions