Skip to content

Page sidebar/vertical nav breakpoint changed #4087

@mcoker

Description

@mcoker

patternfly/patternfly#2962

We changed the breakpoint at which the vertical nav is hidden. This also introduced some page component chrome spacing changes so that the horizontal spacers in the header, sidebar, page sections, and certain components in the page section (tables, data-lists, tabs, wizard) become more compact at this new breakpoint (this was pre-existing behavior at the old breakpoint, just updated to happen at the new breakpoint instead).

I don't believe this will require any changes in react, but I would like to verify just in case there is some logic with the page component toggle that referenced the old breakpoint, and just as a general smoke test to make sure everything behaves correctly after pulling in this update.

Update - after doing some more investigation, looks like the managed sidebar code will need to be updated -

const mobileView = windowSize < Number.parseInt(globalBreakpointMd.value, 10);

Metadata

Metadata

Assignees

Labels

Breaking change 💥this change requires a major release and has API changes.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions