Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V6 rebase #10033

Merged
merged 99 commits into from
Jan 25, 2024
Merged

V6 rebase #10033

merged 99 commits into from
Jan 25, 2024

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Jan 22, 2024

What: Closes #10032

Additional issues:

mcoker and others added 30 commits November 2, 2023 09:49
@mcoker
fix(RTL): added right-to-left page demo (patternfly#9694)
d7308ae
@patternfly-build
chore(release): releasing packages [ci skip]
e9f0b21 
 - @patternfly/react-code-editor@5.2.0-prerelease.20
 - @patternfly/react-core@5.2.0-prerelease.20
 - @patternfly/react-docs@6.2.0-prerelease.20
 - demo-app-ts@5.1.1-prerelease.43
 - @patternfly/react-table@5.2.0-prerelease.20
@jpuzz0
fix(Wizard): onStepChange - skip isDisabled & isHidden (patternfly#9748)
4d4d623
@tlabaj
fix(Text input): Added aria-expanded (patternfly#9705)
7f6a62c 
* fix(Text input): Added aria-expanded

* add interface

* updates from review
@tlabaj
fix(Notification Drawer): Added screen reader text for notification d…
bc19f91 
…rawer item read state (patternfly#9569)

* fix(Notification Drawer): Added screen reader text for notification drawer item read state

* fix snapshot

* Update prop description

* add aria-live

* update snapshots
@adamviktora
feat(Wizard): ability to add props to WizardFooter buttons (patternfl…
9f21cee 
…y#9709)

* feat: ability to add props to WizardFooter buttons

* fix(WizardFooter): null check

* fix(Wizard): simpler design of adding footer buttons props

* test(Wizard): can add props to footer buttons

* docs(WizardFooter): move comment so docs have correct description

* refactor(WizardFooter): move FooterButtonProps to types file
@mfrances17
chore(Divider): update tests to new standards (patternfly#9714)
7eff077 
* chore(Divider): update tests to new standards

* changes from PR review
@patternfly-build
chore(release): releasing packages [ci skip]
4f459eb 
 - @patternfly/react-code-editor@5.2.0-prerelease.21
 - @patternfly/react-core@5.2.0-prerelease.21
 - @patternfly/react-docs@6.2.0-prerelease.21
 - demo-app-ts@5.1.1-prerelease.44
 - @patternfly/react-table@5.2.0-prerelease.21
@kmcfaul
fix(TreeView): define button type (patternfly#9770)
a772c6d
@wise-king-sullyman
bug(build): fixed built ESM files importing CJS files from react-styl…
817e9bd 
…es (patternfly#9347)

* bug(build): fixed built ESM files importing CJS files from react-styles

* edited yarn.lock to invalidate deps cache in GH actions

* excluded file extensions from react-styles path transform in ESM build

* updated jest config to transform .mjs files

* updated pr action to invalidate deps cache if package files added/edited

* chore(deps): Add ts-node to support executing typescript files directly
@patternfly-build
chore(release): releasing packages [ci skip]
5febe85 
 - @patternfly/react-code-editor@5.2.0-prerelease.22
 - @patternfly/react-core@5.2.0-prerelease.22
 - @patternfly/react-docs@6.2.0-prerelease.22
 - demo-app-ts@5.1.1-prerelease.45
 - @patternfly/react-table@5.2.0-prerelease.22
 - transformer-react-styles-esm-imports@1.0.1-prerelease.0
@renovate
chore(deps): update dependency @patternfly/patternfly to v5.2.0-prere…
fc2907d 
…lease.4 (patternfly#9780)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@patternfly-build
chore(release): releasing packages [ci skip]
559e6fd 
 - @patternfly/react-charts@7.2.0-prerelease.6
 - @patternfly/react-code-editor@5.2.0-prerelease.23
 - @patternfly/react-core@5.2.0-prerelease.23
 - @patternfly/react-docs@6.2.0-prerelease.23
 - @patternfly/react-icons@5.2.0-prerelease.6
 - demo-app-ts@5.1.1-prerelease.46
 - @patternfly/react-styles@5.2.0-prerelease.4
 - @patternfly/react-table@5.2.0-prerelease.23
 - @patternfly/react-tokens@5.2.0-prerelease.5
@Kells512 @nicolethoen @thatblindgeye
feat(Datalist): implement full page Basic demo to match HTML patternf…
ab18059 
…ly#9048 (patternfly#9087)

* feat(Datalist): implement full page Basic demo to match HTML patternfly#9048

* fix syntax error

* comments applied

* comments applied

* comments applied

* comments applied

* \xa0 comments applied

* move key per review comments

* address PR comments

* revert change to package.json

* Converted basic demo to TS

---------

Co-authored-by: nicolethoen <nthoen@redhat.com>
Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com>
@adamviktora
fix(ClipboardCopy): kepp caret position (patternfly#9772)
981361e
@patternfly-build
chore(release): releasing packages [ci skip]
74773b0 
 - @patternfly/react-code-editor@5.2.0-prerelease.24
 - @patternfly/react-core@5.2.0-prerelease.24
 - @patternfly/react-docs@6.2.0-prerelease.24
 - demo-app-ts@5.1.1-prerelease.47
 - @patternfly/react-table@5.2.0-prerelease.24
@renovate
chore(deps): update devdependencies (patternfly#9757)
b3345c2 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency @patternfly/patternfly to v5.2.0-prere…
3131ff6 
…lease.5 (patternfly#9806)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update devdependencies (patternfly#9800)
93db0ff 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@patternfly-build
chore(release): releasing packages [ci skip]
75442bf 
 - @patternfly/react-charts@7.2.0-prerelease.7
 - @patternfly/react-code-editor@5.2.0-prerelease.25
 - @patternfly/react-core@5.2.0-prerelease.25
 - @patternfly/react-docs@6.2.0-prerelease.25
 - @patternfly/react-icons@5.2.0-prerelease.7
 - demo-app-ts@5.1.1-prerelease.48
 - @patternfly/react-styles@5.2.0-prerelease.5
 - @patternfly/react-table@5.2.0-prerelease.25
 - @patternfly/react-tokens@5.2.0-prerelease.6
@thatblindgeye
fix(DatePicker): updated logic for parsing and focus management (patt…
a12cf31 
…ernfly#9794)
@patternfly-build
chore(release): releasing packages [ci skip]
9dccfa9 
 - @patternfly/react-code-editor@5.2.0-prerelease.26
 - @patternfly/react-core@5.2.0-prerelease.26
 - @patternfly/react-docs@6.2.0-prerelease.26
 - demo-app-ts@5.1.1-prerelease.49
 - @patternfly/react-table@5.2.0-prerelease.26
@jenny-s51
chore(PrimaryDetail): convert demos to TS (patternfly#9787)
bf96edb
@patternfly-build
chore(release): releasing packages [ci skip]
42fd765 
 - @patternfly/react-code-editor@5.2.0-prerelease.27
 - @patternfly/react-core@5.2.0-prerelease.27
 - @patternfly/react-docs@6.2.0-prerelease.27
 - demo-app-ts@5.1.1-prerelease.50
 - @patternfly/react-table@5.2.0-prerelease.27
@jenny-s51
chore(misc): clean up instances of Array.apply (patternfly#9798)
705e9ff 
* clean up instances of Array.apply

* rename item to value
@patternfly-build
chore(release): releasing packages [ci skip]
e96ac1d 
 - @patternfly/react-code-editor@5.2.0-prerelease.28
 - @patternfly/react-core@5.2.0-prerelease.28
 - @patternfly/react-docs@6.2.0-prerelease.28
 - @patternfly/react-integration@5.1.1-prerelease.15
 - demo-app-ts@5.1.1-prerelease.51
 - @patternfly/react-table@5.2.0-prerelease.28
@wise-king-sullyman
chore(eslint): Added React Testing Library linter plugin (patternfly#…
9b9622d 
…9805)
@patternfly-build
chore(release): releasing packages [ci skip]
4f123b1 
 - @patternfly/react-code-editor@5.2.0-prerelease.29
 - @patternfly/react-core@5.2.0-prerelease.29
 - @patternfly/react-docs@6.2.0-prerelease.29
 - @patternfly/react-icons@5.2.0-prerelease.8
 - demo-app-ts@5.1.1-prerelease.52
 - @patternfly/react-table@5.2.0-prerelease.29
@kmcfaul
chore(DataList): update tests (patternfly#9672)
2a70043 
* add spread prop test, update test

* chore(DataList): update tests

* fix merge error

* break out into separate files, pr feedback

* updates

* fix some example ids

* minor test updates

* revert action change
@gitdallas
bug(ClipboardCopy): change children type to string (patternfly#9743)
a414253 
* bug(ClipboardCopy): change children type to string

Signed-off-by: gitdallas <dallas.nicol@gmail.com>

* fix clipboardcopyexpanded to work with string children

Signed-off-by: gitdallas <dallas.nicol@gmail.com>

* refactor a bit

* fix bad rebase

---------

Signed-off-by: gitdallas <dallas.nicol@gmail.com>
patternfly-build and others added 16 commits January 10, 2024 16:52
@patternfly-build
chore(release): releasing packages [ci skip]
53398c8 
 - @patternfly/react-code-editor@5.2.0-prerelease.45
 - @patternfly/react-core@5.2.0-prerelease.44
 - @patternfly/react-docs@6.2.0-prerelease.45
 - @patternfly/react-drag-drop@5.2.0-prerelease.2
 - demo-app-ts@5.1.1-prerelease.67
 - @patternfly/react-table@5.2.0-prerelease.44
@vojtechszocs
Update react-core dist/dynamic to include exported styles (patternfly…
c14c48c 
…#9939)
@patternfly-build
chore(release): releasing packages [ci skip]
af457ce 
 - @patternfly/react-charts@7.2.0-prerelease.9
 - @patternfly/react-code-editor@5.2.0-prerelease.46
 - @patternfly/react-core@5.2.0-prerelease.45
 - @patternfly/react-docs@6.2.0-prerelease.46
 - @patternfly/react-drag-drop@5.2.0-prerelease.3
 - @patternfly/react-icons@5.2.0-prerelease.10
 - demo-app-ts@5.1.1-prerelease.68
 - @patternfly/react-table@5.2.0-prerelease.45
@renovate
chore(deps): update devdependencies (patternfly#9955)
10a26e6 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jamestalton @nicolethoen
FileUploadField fix to set name attribute on input element (patternfl…
2dab51f 
…y#9941)

* FileUploadField name attribute fix

* update snapshots

* prevent breaking change

---------

Co-authored-by: nicolethoen <nthoen@redhat.com>
@patternfly-build
chore(release): releasing packages [ci skip]
77f45e5 
 - @patternfly/react-code-editor@5.2.0-prerelease.47
 - @patternfly/react-core@5.2.0-prerelease.46
 - @patternfly/react-docs@6.2.0-prerelease.47
 - @patternfly/react-drag-drop@5.2.0-prerelease.4
 - demo-app-ts@5.1.1-prerelease.69
 - @patternfly/react-table@5.2.0-prerelease.46
@renovate
chore(deps): update devdependencies (patternfly#9967)
15c5ee9 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@dlabrecq
Update Victory dependencies (patternfly#9963)
61aac62 
* feat(charts): Victory dependency update

Closes patternfly#9960

* chore(charts): update lodash dependency
@patternfly-build
chore(release): releasing packages [ci skip]
cec6e41 
 - @patternfly/react-charts@7.2.0-prerelease.10
 - @patternfly/react-docs@6.2.0-prerelease.48
@tlabaj
fix(Clipboard copy): Fixed regression with updating main content when…
a189781 
… expanded (patternfly#9975)
@patternfly-build
chore(release): releasing packages [ci skip]
c856b07 
 - @patternfly/react-code-editor@5.2.0-prerelease.48
 - @patternfly/react-core@5.2.0-prerelease.47
 - @patternfly/react-docs@6.2.0-prerelease.49
 - @patternfly/react-drag-drop@5.2.0-prerelease.5
 - demo-app-ts@5.1.1-prerelease.70
 - @patternfly/react-table@5.2.0-prerelease.47
@adamviktora
fix(ClipboardCopy): update main content on children change when expan…
9395dd5 
…ded (patternfly#10015)
@patternfly-build
chore(release): releasing packages [ci skip]
08e52e3 
 - @patternfly/react-code-editor@5.2.0-prerelease.49
 - @patternfly/react-core@5.2.0-prerelease.48
 - @patternfly/react-docs@6.2.0-prerelease.50
 - @patternfly/react-drag-drop@5.2.0-prerelease.6
 - demo-app-ts@5.1.1-prerelease.71
 - @patternfly/react-table@5.2.0-prerelease.48
@kmcfaul
feat(DragDrop): fix import warning (patternfly#10023)
e3fe70f
@patternfly-build
chore(release): releasing packages [ci skip]
f62813f 
 - @patternfly/react-docs@6.2.0-prerelease.51
 - @patternfly/react-drag-drop@5.2.0-prerelease.7
Merge branch 'main' into v6_rebase
0d72ea1
@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 22, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-10033.surge.sh

A11y report: https://patternfly-react-pr-10033-a11y.surge.sh

thatblindgeye
thatblindgeye approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My updates from main look good, Accordion is working well with both main + v6 updates I had made.

Am noticing that in dark theme the accordion toggle's hover styling is no longer working/the same as when the core PR went in. @lboehling was there an update made to either the --pf-t--global--background--color--action--plain--default or --pf-t--global--background--color--action--plain--hover tokens recently? When I build the core repo locally I'm also noticing that the background color isn't changing on hover in dark theme on the accordion toggle, but in the original core PR it's working fine.

@lboehling
Copy link
Collaborator

lboehling commented Jan 24, 2024 •
edited
Loading

Am noticing that in dark theme the accordion toggle's hover styling is no longer working/the same as when the core PR went in. @lboehling was there an update made to either the --pf-t--global--background--color--action--plain--default or --pf-t--global--background--color--action--plain--hover tokens recently? When I build the core repo locally I'm also noticing that the background color isn't changing on hover in dark theme on the accordion toggle, but in the original core PR it's working fine.

@thatblindgeye no, there haven't been any updates made to those tokens recently as far as i know. Is the mix blend mode token being added to the hover state?

I'm also noticing that the expanded state bkg looks different from the original core PR too.

@lboehling lboehling mentioned this pull request Jan 24, 2024
Closed
@kmcfaul kmcfaul merged commit 4a58c89 into patternfly:v6 Jan 25, 2024
13 checks passed
@tlabaj tlabaj mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.