Skip to content

feat(Popper): add passthrough for offset #11994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wise-king-sullyman merged 2 commits into from
Sep 10, 2025
Merged

feat(Popper): add passthrough for offset #11994

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c078843
feat(Popper): add passthrough for offset
kmcfaul Sep 5, 2025
e401941
update to use popper's offset interface
kmcfaul Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/react-core/src/helpers/Popper/Popper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { cloneElement, isValidElement, useCallback, useEffect, useMemo, useRef, useState } from 'react';
import * as ReactDOM from 'react-dom';
import { usePopper } from './thirdparty/react-popper/usePopper';
import { Options as OffsetOptions } from './thirdparty/popper-core/modifiers/offset';
import { Placement, Modifier } from './thirdparty/popper-core';
import { clearTimeouts } from '../util';
import { css } from '@patternfly/react-styles';
Expand Down Expand Up @@ -107,6 +108,8 @@ export interface PopperProps {
};
/** Distance of the popper to the trigger */
distance?: number;
/** Override for the popper's offset */
offset?: OffsetOptions['offset'];
/** Callback function when mouse enters trigger */
onMouseEnter?: (event?: MouseEvent) => void;
/** Callback function when mouse leaves trigger */
Expand Down Expand Up @@ -190,6 +193,7 @@ export const Popper: React.FunctionComponent<PopperProps> = ({
isVisible = true,
positionModifiers,
distance = 0,
offset,
onMouseEnter,
onMouseLeave,
onFocus,
Expand Down Expand Up @@ -420,7 +424,7 @@ export const Popper: React.FunctionComponent<PopperProps> = ({
{
name: 'offset',
options: {
offset: [0, distance]
offset: offset || [0, distance]
}
},
{
Expand Down
Loading