fix(build): Support building Gatsby app under Windows #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoStaudinger
changed the title
Collaborator
|
PatternFly-React preview: https://1248-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4125
💛 - Coveralls |
TimoStaudinger
changed the title
jschuler
approved these changes
Jan 25, 2019
kmcfaul
approved these changes
Jan 28, 2019
dlabaj
approved these changes
Jan 29, 2019
This was referenced Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes #1246.
Windows uses backslashes instead of the Unix style forward slashes to separate file path segments.
This caused problems with the Gatsby build of the PF4 react-docs package.
These changes should resolve this by taking both types of slashes into account in the build scripts.