Skip to content

Conversation

@redallen
Copy link
Contributor

@redallen redallen commented Feb 19, 2019

What: Fix linting glob and start linting code again.

Additional issues: Even after running eslint --fix there are still 912 linter problems. Lots of them are opinionated and will need to be iterated through slowly in order to resolve #1256.

Edit: Breakdown of 902 errors:

 318 camelcase
 234 import/no-extraneous-dependencies
 138 react/require-default-props
  80 react/prefer-stateless-function
  49 react/prop-types
  26 no-unused-vars
  26 import/no-unresolved
   8 jest/valid-expect
   5 react/no-find-dom-node
   3 react/default-props-match-prop-types
   3 prefer-destructuring
   3 no-nested-ternary
   2 consistent-return
   1 react/no-unused-state
   1 react/no-did-mount-set-state
   1 no-template-curly-in-string
   1 no-restricted-globals
   1 no-debugger
   1 jsx-a11y/no-redundant-roles
   1 class-methods-use-this

@redallen redallen changed the title fix(lint): fix linting glob and auto-fixable errors (#1256) fix(lint): fix linting glob and auto-fixable linter errors (#1256) Feb 19, 2019
@AllenBW
Copy link
Contributor

AllenBW commented Feb 20, 2019

As an Allen, I support this pr. 😋 🌮 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JS lint npm script broken for patternfly-4 packages

4 participants