Update React 16.4 (mixed versions) to React 16.8 #1541

redallen · 2019-03-11T15:30:09Z

What:

Upgrade and lock to React 16.8 across all projects.
Upgrade and lock to Enzyme 3.9.0.
Remove broken commitlint package since we no longer enforce semantic commits
Update some test selectors for new Enzyme-react adapter
Fix Gatsby by making it ignore *.d.ts files
Huge yarn.lock bump
Fix Avatar in Gatsby docs

Additional issues: ~~Pf4 doc build is broken. Working with @jschuler to fix.~~ Fixed

codecov-io · 2019-03-11T17:30:44Z

Codecov Report

Merging #1541 into master will increase coverage by 0.2%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1541     +/-   ##
=========================================
+ Coverage   83.62%   83.82%   +0.2%     
=========================================
  Files         552      556      +4     
  Lines        5751     5856    +105     
  Branches       12       12             
=========================================
+ Hits         4809     4909    +100     
- Misses        940      945      +5     
  Partials        2        2

Flag	Coverage Δ
#patternfly3	`84.89% <ø> (ø)`	⬆️
#patternfly4	`81.4% <ø> (ø)`	⬆️
#patternflymisc	`95.65% <ø> (?)`

Impacted Files	Coverage Δ
test.env.js	`100% <ø> (ø)`	⬆️
...y-3/patternfly-react/src/common/closestPolyfill.js	`81.81% <0%> (-9.1%)`	⬇️
packages/react-icons/src/common.js	`100% <0%> (ø)`
packages/react-icons/src/createIcon.js	`100% <0%> (ø)`
packages/react-codemods/transforms/pf3-pf4.js	`94.04% <0%> (ø)`
packages/react-codemods/componentConfig.js	`100% <0%> (ø)`
...ernfly-3/patternfly-react/src/common/controlled.js	`75% <0%> (+5%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4edacf0...db56c96. Read the comment docs.

dgutride · 2019-03-11T18:08:35Z

@redallen - we'd like to get this tested with two other products to ensure there are no breaking changes. Also - what is left to get the do not merge label removed?

redallen · 2019-03-11T18:11:50Z

All that's left is getting gatsby doc generation working. Weird typescript-related errors are occurring.

patternfly-build · 2019-03-11T20:55:40Z

PatternFly-React preview: https://1541-pr-patternfly-react-patternfly.surge.sh

dgutride

Generally - I think this looks good, mostly snapshot updates. In the future, it would be good to break these into much smaller PR's to ease reviewing. For instance - could we have only updated PF4 at this time - should we make sure any react dependencies are decoupled between pf3 and pf4 to allow them to move independently?

package.json

patternfly-build · 2019-03-12T15:32:04Z

PatternFly-React preview: https://1541-pr-patternfly-react-patternfly.surge.sh

mturley · 2019-03-12T20:17:00Z

packages/patternfly-4/react-core/src/components/ChipGroup/__snapshots__/Chip.test.js.snap

-/>
+>
+  <Component />
+</GenerateId>


This is a pre-existing problem, but we should probably revisit these snapshot tests later. A snapshot of a shallow render of something wrapped by GenerateId or ContextConsumer isn't accomplishing anything.

...ages/patternfly-4/react-core/src/components/Dropdown/__snapshots__/DropdownItem.test.js.snap

mturley · 2019-03-12T20:26:52Z

packages/patternfly-4/react-docs/src/components/propsTableTs/propsTableTs.js

    </Table>
  </Section>
 );
+// {props.map(prop => (


We should avoid committing commented-out code, right?

Also, when trying to check the effects of removing this, I went to look at the props table for Avatar and on https://1541-pr-patternfly-react-patternfly.surge.sh/patternfly-4/components/avatar I'm getting a blank page with console errors:

TypeError: Cannot read property 'name' of null at getEnumValue (propsTable.js:68) at propsTable.js:53 at Array.map (<anonymous>) at PropsTable (propsTable.js:49) at hg (react-dom.production.min.js:150) at Tg (react-dom.production.min.js:178) at bi (react-dom.production.min.js:232) at ci (react-dom.production.min.js:233) at Di (react-dom.production.min.js:249) at Yh (react-dom.production.min.js:248) qh @ react-dom.production.min.js:198 react-dom.production.min.js:248 Uncaught TypeError: Cannot read property 'name' of null at getEnumValue (propsTable.js:68) at propsTable.js:53 at Array.map (<anonymous>) at PropsTable (propsTable.js:49) at hg (react-dom.production.min.js:150) at Tg (react-dom.production.min.js:178) at bi (react-dom.production.min.js:232) at ci (react-dom.production.min.js:233) at Di (react-dom.production.min.js:249) at Yh (react-dom.production.min.js:248)

Yeah, that's a problem. @jschuler has found a way around it in #1539. For now I'll find a way to disable more functionality for the time being.

Fixed in latest commit by changing a little bit of Gatsby logic. New preview should deploy shortly.

New preview doesn't seem to have console errors for Avatar: https://1541-pr-patternfly-react-patternfly.surge.sh/patternfly-4/components/avatar

.gitignore

packages/patternfly-4/react-core/scripts/convertComponentHelpers.js

mturley

This is great work @redallen, I especially love the scripts for converting components to TS! Just left a couple of minor comments.

dlabaj

LGTM

mturley

LGTM 🎉
Can't wait to build some stuff with Hooks.

redallen mentioned this pull request Mar 11, 2019

New tree view integration #864

Merged

redallen self-assigned this Mar 11, 2019

redallen added chore 🏠 Infrastructure Do Not Merge labels Mar 11, 2019

redallen mentioned this pull request Mar 11, 2019

fix(build): Support running the test suite under Windows #1255

Merged

redallen added 11 commits March 11, 2019 16:31

lock enzyme deps

55e8901

don't render typescript props in docs

c586bbf

add regex scripts

c59acbb

format build commands

a385f44

lock typescript version

0d23754

Upgrade to React 16.8

e12a789

Update tests for new Enzyme adapter

3e552b4

Update snapshots

f6098c6

Fix pf3 doc build

3532683

Fix duallist test for Travis

111edb4

fix docbuild

e7e1154

redallen force-pushed the chore/react-16.8 branch from bd4d925 to e7e1154 Compare March 11, 2019 20:36

redallen added 2 commits March 11, 2019 16:41

bump yarn.lock

01a577b

gitignore prettier files

d085dee

redallen changed the title ~~[WIP] Update React 16.4 (mixed versions) to React 16.8~~ Update React 16.4 (mixed versions) to React 16.8 Mar 11, 2019

redallen removed the Do Not Merge label Mar 11, 2019

fix rebased snapshot, might as well have merged

6add90c

redallen requested review from dgutride, jeff-phillips-18 and tlabaj March 11, 2019 21:21

redallen requested review from dlabaj and dmiller9911 March 11, 2019 21:21

dgutride removed the request for review from dmiller9911 March 12, 2019 13:00

dgutride suggested changes Mar 12, 2019

View reviewed changes

package.json Show resolved Hide resolved

redallen added 2 commits March 12, 2019 10:13

downgrade tippy to fix application launcher

b07a471

Fix master merge conflicts

29e3990

Readd commitizen

a61d12d

dgutride previously approved these changes Mar 12, 2019

View reviewed changes

mturley reviewed Mar 12, 2019

View reviewed changes

...ages/patternfly-4/react-core/src/components/Dropdown/__snapshots__/DropdownItem.test.js.snap Show resolved Hide resolved

mturley reviewed Mar 12, 2019

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

mturley reviewed Mar 12, 2019

View reviewed changes

packages/patternfly-4/react-core/scripts/convertComponentHelpers.js Outdated Show resolved Hide resolved

mturley reviewed Mar 12, 2019

View reviewed changes

redallen added 3 commits March 12, 2019 16:34

fix .gitignore

45ebac6

remove commented code

5ab20ac

fix gatsby ts docs

db56c96

redallen dismissed dgutride’s stale review via db56c96 March 12, 2019 20:50

dlabaj approved these changes Mar 13, 2019

View reviewed changes

mturley approved these changes Mar 13, 2019

View reviewed changes

dgutride merged commit 86a4715 into master Mar 13, 2019

redallen deleted the chore/react-16.8 branch March 18, 2019 13:17

Update React 16.4 (mixed versions) to React 16.8 #1541

Update React 16.4 (mixed versions) to React 16.8 #1541

Uh oh!

Conversation

redallen commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dgutride commented Mar 11, 2019

Uh oh!

redallen commented Mar 11, 2019

Uh oh!

patternfly-build commented Mar 11, 2019

Uh oh!

dgutride left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

patternfly-build commented Mar 12, 2019

Uh oh!

mturley Mar 12, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mturley Mar 12, 2019

Choose a reason for hiding this comment

Uh oh!

redallen Mar 12, 2019

Choose a reason for hiding this comment

Uh oh!

redallen Mar 12, 2019

Choose a reason for hiding this comment

Uh oh!

redallen Mar 12, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mturley left a comment

Choose a reason for hiding this comment

Uh oh!

dlabaj left a comment

Choose a reason for hiding this comment

Uh oh!

mturley left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

redallen commented Mar 11, 2019 •

edited

Loading

codecov-io commented Mar 11, 2019 •

edited

Loading