Skip to content

Conversation

@redallen
Copy link
Contributor

What: See title. Should fail PRs like #1255 that break packages/react-* tests.

Additional issues:

@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://1556-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #1556 into master will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1556     +/-   ##
=========================================
+ Coverage   83.62%   83.82%   +0.2%     
=========================================
  Files         552      556      +4     
  Lines        5751     5856    +105     
  Branches       12       12             
=========================================
+ Hits         4809     4909    +100     
- Misses        940      945      +5     
  Partials        2        2
Flag Coverage Δ
#patternfly3 84.89% <ø> (ø) ⬆️
#patternfly4 81.4% <ø> (ø) ⬆️
#patternflymisc 95.65% <ø> (?)
Impacted Files Coverage Δ
packages/react-icons/src/common.js 100% <0%> (ø)
packages/react-icons/src/createIcon.js 100% <0%> (ø)
packages/react-codemods/transforms/pf3-pf4.js 94.04% <0%> (ø)
packages/react-codemods/componentConfig.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a937417...888d9e0. Read the comment docs.

@dlabaj dlabaj merged commit 5abfbdc into patternfly:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants