Skip to content

Conversation

@dtaylor113
Copy link
Member

Convert Tooltip component to Typescript.
Update unit and system integration tests.

Addresses #2212

@dtaylor113 dtaylor113 requested review from dlabaj and redallen June 11, 2019 19:09
@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://2216-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

codecov-io commented Jun 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@263c572). Click here to learn what that means.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2216   +/-   ##
=========================================
  Coverage          ?   79.96%           
=========================================
  Files             ?      669           
  Lines             ?     8550           
  Branches          ?      732           
=========================================
  Hits              ?     6837           
  Misses            ?     1362           
  Partials          ?      351
Flag Coverage Δ
#patternfly3 85.23% <ø> (?)
#patternfly4 75.08% <91.66%> (?)
#patternflymisc 95.79% <ø> (?)
Impacted Files Coverage Δ
...ly-4/react-core/src/components/Popover/Popover.tsx 62.96% <ø> (ø)
...rnfly-4/react-core/src/components/Tooltip/index.ts 100% <100%> (ø)
...act-core/src/components/Tooltip/TooltipContent.tsx 100% <100%> (ø)
...react-core/src/components/Tooltip/TooltipArrow.tsx 80% <80%> (ø)
...ly-4/react-core/src/components/Tooltip/Tooltip.tsx 84% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 263c572...babea7f. Read the comment docs.

@dtaylor113 dtaylor113 force-pushed the tooltip-typescript branch 2 times, most recently from c9398f8 to 8237557 Compare June 17, 2019 16:50
@dtaylor113
Copy link
Member Author

dtaylor113 commented Jun 18, 2019

@redallen, any idea why all CI tests are failing with '...exited with 127.'? They all work locally for me. -thanks.
UPDATE: Ok, I see #2287 which maybe to address these failures

@redallen
Copy link
Contributor

@dtaylor113 Yep, Travis decided to stop caching inter-job dist directories randomly yesterday, so I'm in the process of moving everything to CircleCI now. I'll let you know when it's in and you can rebase.

className={null}
>
<Unknown />
<Unknown>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why the snapshot updated to Unknown?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I saw that as well, I do not know, I thought it might have to do with the unit test using const view = shallow(...

@dtaylor113
Copy link
Member Author

Hi @redallen, resolved merge conflicts, PR should be ready for review (again :-) -thanks

@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2216.surge.sh

@redallen redallen merged commit b1bf2c0 into patternfly:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants