-
Notifications
You must be signed in to change notification settings - Fork 377
Convert Tooltip component to Typescript #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
PatternFly-React preview: https://2216-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #2216 +/- ##
=========================================
Coverage ? 79.96%
=========================================
Files ? 669
Lines ? 8550
Branches ? 732
=========================================
Hits ? 6837
Misses ? 1362
Partials ? 351
Continue to review full report at Codecov.
|
c9398f8 to
8237557
Compare
|
@dtaylor113 Yep, Travis decided to stop caching inter-job |
| className={null} | ||
| > | ||
| <Unknown /> | ||
| <Unknown> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why the snapshot updated to Unknown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I saw that as well, I do not know, I thought it might have to do with the unit test using const view = shallow(...
8237557 to
daa24b5
Compare
|
Hi @redallen, resolved merge conflicts, PR should be ready for review (again :-) -thanks |
|
PatternFly-React preview: https://patternfly-react-pr-2216.surge.sh |
Convert Tooltip component to Typescript.
Update unit and system integration tests.
Addresses #2212