Skip to content

Added OUIA compatibility to Dropdown component #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
quarckster wants to merge 1 commit into from
Closed

Added OUIA compatibility to Dropdown component #2388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/patternfly-4/react-core/src/components/Dropdown/Dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import styles from '@patternfly/react-styles/css/components/Dropdown/dropdown';
import { css } from '@patternfly/react-styles';
import DropdownMenu from './DropdownMenu';
import { DropdownPosition, DropdownDirection, DropdownContext } from './dropdownConstants';
import { isOUIAEnvironment, getUniqueId as getOIUAUniqueId } from '../../helpers/ouia';

// seed for the aria-labelledby ID
let currentId = 0;
Expand Down Expand Up @@ -87,6 +88,7 @@ export class DropdownWithContext extends React.Component {
component = 'div';
renderedContent = children;
}
ouiaId = getOIUAUniqueId();
return (
<DropdownContext.Consumer>
{({ baseClass, baseComponent: BaseComponent }) => (
Expand All @@ -101,6 +103,10 @@ export class DropdownWithContext extends React.Component {
ref={ref => {
this.parentRef = ref;
}}
{...isOUIAEnvironment() && {
'data-ouia-component-type': 'Dropdown',
'data-ouia-component-id': this.ouiaId
}}
>
{Children.map(toggle, oneToggle =>
cloneElement(oneToggle, {
Expand Down