Skip to content

fix(LoginForm): removes deprecated rememberMeAriaLabel prop #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jenny-s51 wants to merge 1 commit into from
Closed

fix(LoginForm): removes deprecated rememberMeAriaLabel prop #2516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/patternfly-4/react-core/src/components/LoginPage/LoginForm.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,3 @@ test('LoginForm with rememberMeLabel', () => {
const view = shallow(<LoginForm rememberMeLabel="remember me" />);
expect(view).toMatchSnapshot();
});

test('LoginForm with rememberMeLabel and rememberMeAriaLabel uses the rememberMeAriaLabel', () => {
const view = shallow(<LoginForm rememberMeAriaLabel="ARIA remember me" rememberMeLabel="remember me" />);
expect(view).toMatchSnapshot();
});
5 changes: 0 additions & 5 deletions packages/patternfly-4/react-core/src/components/LoginPage/LoginForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ export interface LoginFormProps extends React.HTMLProps<HTMLFormElement> {
isRememberMeChecked?: boolean;
/** Function that handles the onChange event for the Remember Me Checkbox */
onChangeRememberMe?: (checked: boolean, event: React.FormEvent<HTMLInputElement>) => void;
/* THIS PROP IS DEPRECATED AND NO LONGER USED; remove in a future breaking change release
* Aria Label for the Remember me checkbox, use this to override using the rememberMeLabel
* */
rememberMeAriaLabel?: string;
}

export const LoginForm: React.FunctionComponent<LoginFormProps> = ({
Expand All @@ -63,7 +59,6 @@ export const LoginForm: React.FunctionComponent<LoginFormProps> = ({
rememberMeLabel = '',
isRememberMeChecked = false,
onChangeRememberMe = () => undefined as any,
rememberMeAriaLabel = '',
...props
}: LoginFormProps) => (
<Form className={className} {...props}>
Expand Down
76 changes: 0 additions & 76 deletions ...es/patternfly-4/react-core/src/components/LoginPage/__snapshots__/LoginForm.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,82 +76,6 @@ exports[`LoginForm with rememberMeLabel 1`] = `
</Component>
`;

exports[`LoginForm with rememberMeLabel and rememberMeAriaLabel uses the rememberMeAriaLabel 1`] = `
<Component
className=""
>
<Component
isError={false}
isHidden={true}
/>
<Component
fieldId="pf-login-username-id"
isRequired={true}
isValid={true}
label="Username"
>
<TextInput
aria-label={null}
className=""
id="pf-login-username-id"
isDisabled={false}
isReadOnly={false}
isRequired={true}
isValid={true}
name="pf-login-username-id"
onChange={[Function]}
type="text"
value=""
/>
</Component>
<Component
fieldId="pf-login-password-id"
isRequired={true}
isValid={true}
label="Password"
>
<TextInput
aria-label={null}
className=""
id="pf-login-password-id"
isDisabled={false}
isReadOnly={false}
isRequired={true}
isValid={true}
name="pf-login-password-id"
onChange={[Function]}
type="password"
value=""
/>
</Component>
<Component
fieldId="pf-login-remember-me-id"
>
<Checkbox
checked={false}
className=""
id="pf-login-remember-me-id"
isChecked={false}
isDisabled={false}
isValid={true}
label="remember me"
onChange={[Function]}
/>
</Component>
<Component>
<Component
isBlock={true}
isDisabled={false}
onClick={[Function]}
type="submit"
variant="primary"
>
Log In
</Component>
</Component>
</Component>
`;

exports[`should render Login form 1`] = `
<Component
className=""
Expand Down