fix(inline-styles): remove inject and Stylesheet.parse inline references #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://patternfly-react-pr-2653.surge.sh |
dgutride
requested changes
Aug 8, 2019
| cwd: srcDir | ||
| }); | ||
|
|
||
| files.forEach(file => { |
There was a problem hiding this comment.
I'm concerned about adding any support for inline/required css directly to react-core. Maybe we can consider the use of CSS directly an antipattern and make sure we don't make it easy for people to do. For now, can we put this CSS directly into react-styles instead so we don't add the ability for direct inclusion through react-core?
There was a problem hiding this comment.
ok, will try changing this to something more like:
import '@patternfly/react-styles/css/components/Tooltip/popover-base-styles.css';
as a next step...
There was a problem hiding this comment.
updated! PTAL @dgutride
priley86
force-pushed
the
inline-styles
branch
from
5da69d5 to
d363290
Compare
priley86
force-pushed
the
inline-styles
branch
from
d363290 to
43bcfed
Compare
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Closes #2606
cc: @redallen
Additional issues: