fullscreen examples should have 100% height #2670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2670.surge.sh |
tlabaj
reviewed
Aug 8, 2019
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
Do we need to update docs/website to let the consumer know?
Collaborator
Author
|
Not sure, Core doesn't mention it either, perhaps we should? @mcoker |
Contributor
|
@jschuler yeah, I think we should. I don't think having it in the demo is enough for a user to figure out it's required to make the page component full height. |
redallen
approved these changes
Aug 14, 2019
| code: LiveEdit, | ||
| pre: React.Fragment | ||
| pre: React.Fragment, | ||
| p: componentProps => <Text component="p" {...componentProps} />, |
Contributor
There was a problem hiding this comment.
We (eventually) need to make sure every HTML tag is covered here that doesn't look right inside <div className="theme-pf-c-content">.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particularly noticeable for the page demos
Closes: #1294